-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure webpubsub #59
Azure webpubsub #59
Conversation
src/y-webrtc.js
Outdated
const log = logging.createModuleLogger('y-webrtc') | ||
import { WebPubSubClient } from "@azure/web-pubsub-client"; | ||
|
||
const log = logging.createModuleLogger('y-webrtc-azure-webpubsub') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied this code from a local copy of the module that was renamed to y-webrtc-azure-webpubsub
} | ||
} | ||
|
||
export class SignalingConn extends ws.WebsocketClient { | ||
export class SignalingConn extends Observable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't actually need to extend Observable
since the client subscribes to events, not this class.
I think we can create some |
Closing this, which was opened on the wrong repo. We will eventually separate this work out into a PR for Sorry for the confusion. GitHub insists on making the original repo the base for PRs instead of the fork. |
This likely won't be the final implementation but represents most of the changes that need to be made to make y-webrtc compatible with Azure Web PubSub as a signaling server. The final solution will be to make y-webrtc extensible for swapping out signaling server code. Currently, y-webrtc makes assumptions about the message format and structure, which makes it difficult to plug in a different signaling server.