Merge pull request #71 from livingspec/fix-beforeunload-memory-leak

Fix beforeunload memory leak
yjs · Jun 25, 2021 · 16237ff · 16237ff
2 parents 0007200 + 7afa2e6
commit 16237ff
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/y-websocket.js b/src/y-websocket.js
@@ -277,9 +277,10 @@ export class WebsocketProvider extends Observable {
       broadcastMessage(this, encoding.toUint8Array(encoder))
     }
     if (typeof window !== 'undefined') {
-      window.addEventListener('beforeunload', () => {
+      this._beforeUnloadHandler = () => {
         awarenessProtocol.removeAwarenessStates(this.awareness, [doc.clientID], 'window unload')
-      })
+      };
+      window.addEventListener('beforeunload', this._beforeUnloadHandler)
     }
     awareness.on('update', this._awarenessUpdateHandler)
     this._checkInterval = /** @type {any} */ (setInterval(() => {
@@ -315,6 +316,9 @@ export class WebsocketProvider extends Observable {
     }
     clearInterval(this._checkInterval)
     this.disconnect()
+    if (this._beforeUnloadHandler) {
+      window.removeEventListener('beforeunload', this._beforeUnloadHandler)
+    }
     this.awareness.off('update', this._awarenessUpdateHandler)
     this.doc.off('update', this._updateHandler)
     super.destroy()