Add exit handler for Node.js environments, fix #51 #55 #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces:
exit
handler for Node.js environments.The check isn’t very strict, but I don’t see a reason why someone would benefit from manipulating the check. From what I know it’s pretty complex to make that check harder to manipulate.
A very similar change in lib0 is necessary to make y-websocket work in Node.js (again?). I’ll send a PR there too. Let me know if a change to the PR would make it easier to merge it. Happy to update it.