Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a known-working version of Rust nightly. #1104

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

ltratt
Copy link
Contributor

@ltratt ltratt commented Apr 19, 2024

Rust nightly, as of yesterday, breaks yk. We think this is because of rust-lang/rust#124150 --- if so, hopefully we can switch back to "nightly nightly" in a day or two.

Rust nightly, as of yesterday, breaks yk. We *think* this is because of
rust-lang/rust#124150 --- if so, hopefully we
can switch back to "nightly nightly" in a day or two.
@DianQK
Copy link

DianQK commented Apr 19, 2024

Could you explain more? rust-lang/rust#120614 was already landed two weeks ago.

@ltratt
Copy link
Contributor Author

ltratt commented Apr 19, 2024

@DianQK Ug, yes, you're right: I misread the merge date on that PR. Sorry!

So I don't really know why rust nightly as of 2 days ago works and current rust nightly doesn't...

@vext01 vext01 added this pull request to the merge queue Apr 19, 2024
@DianQK
Copy link

DianQK commented Apr 19, 2024

So I think this is a separate issue; perhaps we can identify the problem and create an issue for it. I haven't seen the CI for this project fail; perhaps the issue is somewhere I can't see?

@ltratt
Copy link
Contributor Author

ltratt commented Apr 19, 2024

It could well be a bug at our end!

Merged via the queue into ykjit:master with commit 7172367 Apr 19, 2024
2 checks passed
@ltratt ltratt deleted the use_fixed_nightly branch April 19, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants