Address ECHILD #1777
Merged
Address ECHILD #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1777 +/- ##
==========================================
- Coverage 68.67% 68.64% -0.04%
==========================================
Files 121 121
Lines 13318 13324 +6
==========================================
Hits 9146 9146
- Misses 4172 4178 +6 |
Signed-off-by: utam0k <[email protected]>
ipuustin
reviewed
Apr 5, 2023
yihuaf
approved these changes
Apr 5, 2023
| _ => (), | ||
| Ok(_) => (), | ||
| Err(err) => { | ||
| if err == Errno::ECHILD { |
There was a problem hiding this comment.
Nit: Can this be turned into Err(Errno::ECHILD) case?
There was a problem hiding this comment.
I think we don't need to do it because waitpid returns Result<T, Errno>
https://docs.rs/nix/latest/nix/type.Result.html
Signed-off-by: utam0k <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assume the case where intermediate_process is waitpid by someone and ignore ECHILD in that case.
This is safe. This is safe because intermediate_process and main_process check if the process is finished by piping instead of exit code.