deps: do not use chrono default-features. #1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1900 +/- ##
=======================================
Coverage 67.36% 67.37%
=======================================
Files 126 126
Lines 14265 14265
=======================================
+ Hits 9610 9611 +1
+ Misses 4655 4654 -1 |
|
Hey @ipuustin Looks good overall, but can you run the build locally and also commit the |
Signed-off-by: Ismo Puustinen <[email protected]>
ipuustin
force-pushed
the
no-chrono-default-features
branch
from
dce38d3 to
131beac
Compare
|
Thanks @ipuustin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
chronodependency not use default features. This is because that's the recommended workaround for atimecrate vulnerability.