Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure theat read only paths work properly. #212

Merged
merged 1 commit into from
Aug 21, 2021

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Aug 21, 2021

In the case of read-only, the flags are ignored on the first bind mount, so it has to be mounted twice.

https://man7.org/linux/man-pages/man2/mount.2.html

Creating a bind mount
....
The filesystemtype and data arguments are ignored.
The remaining bits (other than MS_REC, described below) in the
mountflags argument are also ignored. (The bind mount has the
same mount options as the underlying mount point.) However, see
the discussion of remounting above, for a method of making an
existing bind mount read-only.

@utam0k utam0k requested a review from Furisto August 21, 2021 09:39
@Furisto
Copy link
Collaborator

Furisto commented Aug 21, 2021

lgtm

@Furisto Furisto merged commit 85d0cf6 into youki-dev:main Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants