Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/podman rootless #2368

Closed
wants to merge 9 commits into from
Closed

Conversation

YJDoc2
Copy link
Collaborator

@YJDoc2 YJDoc2 commented Sep 19, 2023

Ref : #2208 , #719 , #1171

This switches from dbus-rs to natively implemented dbus connection implementation, in order to make rootless invocation with podman work. This is almost done but still few final touches are remaining, so marked as WIP.

After ready, I'll edit this to group commits into more easy-to-review way.

@codecov-commenter
Copy link

Codecov Report

Merging #2368 (8293065) into main (23c1f4f) will increase coverage by 1.18%.
Report is 50 commits behind head on main.
The diff coverage is 72.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2368      +/-   ##
==========================================
+ Coverage   64.81%   65.99%   +1.18%     
==========================================
  Files         129      133       +4     
  Lines       15201    16814    +1613     
==========================================
+ Hits         9852    11096    +1244     
- Misses       5349     5718     +369     

@YJDoc2 YJDoc2 marked this pull request as ready for review September 19, 2023 13:29
@YJDoc2
Copy link
Collaborator Author

YJDoc2 commented Sep 19, 2023

Closing because of a rebase

@YJDoc2 YJDoc2 closed this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants