Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass uid_mapping test #289

Merged
merged 2 commits into from
Sep 11, 2021
Merged

Conversation

tommady
Copy link
Collaborator

@tommady tommady commented Sep 10, 2021

#255

by running ./integration_test.sh uid_mapping
below are the current not OK cases

not ok 226 - /dev/null (default device) has the expected type
not ok 228 - /dev/zero (default device) has the expected type
not ok 230 - /dev/full (default device) has the expected type
not ok 232 - /dev/random (default device) has the expected type
not ok 234 - /dev/urandom (default device) has the expected type
not ok 236 - /dev/tty (default device) has the expected type

"actual": "unmatched",
"expected": "c",

@tommady tommady marked this pull request as ready for review September 10, 2021 05:29
@tommady tommady marked this pull request as draft September 10, 2021 05:38
@utam0k
Copy link
Member

utam0k commented Sep 10, 2021

I think this is a very good way to proceed. If you have any problems, please drop me a line.

@tommady tommady marked this pull request as ready for review September 11, 2021 05:30
@tommady
Copy link
Collaborator Author

tommady commented Sep 11, 2021

Hi, I followed the runc code at
libcontainer/rootfs_linux.go:670

and I found out that the nix_mount gave the wrong params sequence.

so seems the checks are all passed, please help review.
thank you 🙇🏻

@utam0k
Copy link
Member

utam0k commented Sep 11, 2021

Could you give me a permalink?

Hi, I followed the runc code at
libcontainer/rootfs_linux.go:670

@tommady
Copy link
Collaborator Author

tommady commented Sep 11, 2021

sure,
https://github.com/opencontainers/runc/blob/master/libcontainer/rootfs_linux.go#L670

Could you give me a permalink?

Hi, I followed the runc code at
libcontainer/rootfs_linux.go:670

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!

@utam0k utam0k merged commit 5d2901e into youki-dev:main Sep 11, 2021
@tommady tommady deleted the pass-uid_mapping-test-#255 branch September 11, 2021 09:40
@yihuaf yihuaf mentioned this pull request Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants