Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yahoo finance.keystats is broken #447

Open
altamont opened this issue Mar 18, 2015 · 7 comments
Open

Yahoo finance.keystats is broken #447

altamont opened this issue Mar 18, 2015 · 7 comments

Comments

@altamont
Copy link

yahoo.finance.keystats just returns the symbol. The old xpath is:

var keystatsquery = y.xpath(
rawresult,
"//table[@Class='yfnc_datamodoutline1']/tr/td/table/tr" +
"/td[@Class='yfnc_tabledata1' or @Class='yfnc_tablehead1']"
);

I think it needs to be changed to:
var keystatsquery = y.xpath(
rawresult,
"//table[@Class='yfnc_datamodoutline1']/tbody/tr/td/table/tbody/tr" +
"/td[@Class='yfnc_tabledata1' or @Class='yfnc_tablehead1']"
);

it looks like there are tbody tags that are throwing it off. i haven't contributed to this project yet, and so i'm a little hesitant to make the change myself. can someone comment as to whether they agree with this?

@TMcClain5
Copy link

I agree with you I believe that should fix the issue. The new tbody tag has to be what is throwing off all of the keystats queries.

@berndsi
Copy link

berndsi commented Mar 31, 2015

+1 I've made similar changes and more to another file (analystestimates) in PR 499.

mgalvey added a commit to mgalvey/yql-tables that referenced this issue Apr 5, 2015
These changes should fix the problem described in yql#447
johnmwilson82 added a commit to johnmwilson82/yql-tables that referenced this issue Apr 13, 2015
These changes should fix the problem described in yql#447
johnmwilson82 added a commit to johnmwilson82/yql-tables that referenced this issue Apr 14, 2015
johnmwilson82 added a commit to johnmwilson82/yql-tables that referenced this issue Apr 14, 2015
@tomasteicher
Copy link

I tried to run YQL query to table "Yahoo finance.keystats" but it still returns only symbols. If I understnad correctly, I need to use Xpath, and not such YQL selects?
I tried:
SELECT * FROM yahoo.finance.keystats WHERE symbol in ("N4E.SI","BS6.SI", "YHOO")
using env value: https://raw.githubusercontent.com/cynwoody/yql-tables/finance-1/tables.env

@BobAleena
Copy link

anyone get this working? I'm still getting back only symbols. Yahoo console keeps giving me a connect failure when i try it there too.

@fho
Copy link

fho commented Dec 15, 2016

Still broken would be awesome if something would get it fixed

@florent522
Copy link

Any update?

@BobAleena
Copy link

Nope - still broken for me. I tried @johnmwilson82's fix from above, but not working for me still

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants