Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): enable/disable api health check not supported by amazon manag… #184

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

melouaer
Copy link
Contributor

…ed grafana

Amazon Managed Grafana does not support api health checks.
Therefore, the backup tool fails with the following error:
[DEBUG] resp body: Bad Request: Not allowed.
This new parameter in the configuration allows us to enable/disable the api health check in order to use the tool.

@ysde
Copy link
Owner

ysde commented Jun 21, 2022

Hi @melouaer
Thank you

@melouaer
Copy link
Contributor Author

Hi @ysde
Thank you for approving the PR.

@pmorelli92
Copy link

Hi people, sorry for bumping this old PR, but I am having errors even with this configuration as the tool tries to get the Grafana version using the /api/health endpoint that is unavailable. So even when the tool does not fail at the beginning, it still fails later.

Traceback (most recent call last):
  File "/Users/pmorelli/.local/bin/grafana-backup", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/pmorelli/.local/pipx/venvs/grafana-backup/lib/python3.12/site-packages/grafana_backup/cli.py", line 52, in main
    save(args, settings)
  File "/Users/pmorelli/.local/pipx/venvs/grafana-backup/lib/python3.12/site-packages/grafana_backup/save.py", line 74, in main
    backup_functions[backup_function](args, settings)
  File "/Users/pmorelli/.local/pipx/venvs/grafana-backup/lib/python3.12/site-packages/grafana_backup/save_alert_rules.py", line 23, in main
    grafana_version = get_grafana_version(
                      ^^^^^^^^^^^^^^^^^^^^
  File "/Users/pmorelli/.local/pipx/venvs/grafana-backup/lib/python3.12/site-packages/grafana_backup/dashboardApi.py", line 506, in get_grafana_version
    raise Exception(
Exception: Unable to get version, returned response: 400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants