fix(alertrules): avoid making alert rules readonly in UI when updated #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything, that can be done to get a review (and merge) for this PR? |
|
Keen on this one too, any updates on possible merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix, so existent alert rule will not move into "Provisioned" state when updated by a restore.
This has been tested on our staging and production environment, by using the following forked version:
https://github.com/vestas-oss/grafana-backup-tool
1 thing to add is that IF someone has run the restore before this fix, the alarts will keep staying in provisioning mode, and the only way to correct this is to delete all alert rules using the grafana API: