x86 Binaries

[Silveryard]

Hi,

Would it be possible to include x86/Win32 Windows binaries into the next release?
Previously I compiled the source myself but now the code triggers an internal compiler error so I cannot build the library...

Silveryard

[rationalcoder]

I don't have any influence over what they provide in the releases, but can you provide an example of the error?

[cas4ey]

Hi @Silveryard
Can you provide the compiler version which causes build error, please?

[cas4ey]

@Silveryard I have tried to build x86 binaries of profiler-core by both Visual Studio 2013 and 2015 and it have been built with no problems.

I have not tried to build profiler_gui though, because I have no x86 Qt binaries, but anyway I recommend to use only x86_64 version of profiler_gui, because it can eat a lot of memory on very big files.

If you are interested I can add x86 binaries of profiler-core only.

[cas4ey]

@Silveryard here you are

[Silveryard]

Thank you very much. I have no problem using x86_64 gui binaries. But my projects are currently locked to x86 so I needed 32bit libraries.

For completion my compiler output: https://gist.github.com/Silveryard/0c320cca0c40034ab005913b4dad16b6
As stated it´s an internal compiler error and I could not figure out what the problem was

[cas4ey]

Hm... something bad happened in VS2017 at this line.

It would be cool if you can figure out how to change this source-code for building in VS2017 (I have no VS2017 installed yet). Please, use #if defined(_MSC_VER) && _MSC_VER >= 1910 for the fixes if you will try to fix it.

The idea of this hash class is to use hashing only for those types which sizeof is greater than sizeof(size_t), and this is our case, because sizeof(thread_id_t) == 8 and sizeof(size_t) == 4 for x86 build.

Maybe replacing the line using ::std::hash<T>::operator(); with next code would help:

inline size_t operator () (const T& value) const {
    return ::std::hash<T>::operator(value);
}

[Silveryard]

I will try and report back!