rename function names related to versions #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current function name is quite generic and it's easy to conflict with other functions in a project since they're C functions
|
The |
Renamed. However, not sure if the author is actively accepting PRs and merge that to the mainline. |
|
Hi! There are a few changes that I should merge and make new major release. The fix is good to up a major version, also migrate to Qt6. Thank you for your contribution. I think I will find time and energy to make project more freshy) |
|
Great work 🏆 Thank you I’ll be updating the major version to 3 to stay aligned with semantic versioning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current function name is quite generic and it's easy to conflict
with other functions in a project since they're C functions