Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/twitter] fix extraction through rest api on links to retweet id #6422

Merged
merged 3 commits into from
Mar 4, 2023
Merged

[extractor/twitter] fix extraction through rest api on links to retweet id #6422

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97ece9f
[extractor/twitter] fix extraction through rest api on links to retwe…
selfisekai Mar 4, 2023
ca87572
[extractor/twitter] review change
selfisekai Mar 4, 2023
b6f6a0d
[extractor/twitter] review change (again)
selfisekai Mar 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions yt_dlp/extractor/twitter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -838,6 +838,28 @@ class TwitterIE(TwitterBaseIE):
'timestamp': 1670306984.0,
},
'params': {'extractor_args': {'twitter': {'force_graphql': ['']}}},
}, {
# url to retweet id
'url': 'https://twitter.com/liberdalau/status/1623739803874349067',
'info_dict': {
'id': '1623274794488659969',
'display_id': '1623739803874349067',
'ext': 'mp4',
'title': 'Johnny Bullets - Me after going viral to over 30million people: Whoopsie-daisy',
'description': 'md5:e873616a4a8fe0f93e71872678a672f3',
'uploader': 'Johnny Bullets',
'uploader_id': 'Johnnybull3ts',
'uploader_url': 'https://twitter.com/Johnnybull3ts',
'age_limit': 0,
'tags': [],
'duration': 8.033,
'timestamp': 1675853859.0,
'upload_date': '20230208',
'thumbnail': r're:https://pbs\.twimg\.com/ext_tw_video_thumb/.+',
'like_count': int,
'repost_count': int,
'comment_count': int,
},
}, {
# onion route
'url': 'https://twitter3e4tixl4xyajtrzo62zg5vztmjuricljdp2c5kshju4avyoid.onion/TwitterBlue/status/1484226494708662273',
Expand Down Expand Up @@ -949,13 +971,13 @@ def _real_extract(self, url):
status = self._graphql_to_legacy(result, twid)

else:
status = self._call_api(f'statuses/show/{twid}.json', twid, {
status = traverse_obj(self._call_api(f'statuses/show/{twid}.json', twid, {
'cards_platform': 'Web-12',
'include_cards': 1,
'include_reply_count': 1,
'include_user_entities': 0,
'tweet_mode': 'extended',
})
}), (('retweeted_status', None),), get_all=False)
selfisekai marked this conversation as resolved.
Show resolved Hide resolved

title = description = status['full_text'].replace('\n', ' ')
# strip 'https -_t.co_BJYgOjSeGA' junk from filenames
Expand Down