Merge pull request #4264 from neutrinoceros/hotfix_4263

BUG: fix calling PlotContainer.set_font to set font color

yt/visualization/base_plot_types.py

@@ -200,7 +200,7 @@ def _set_font_properties(self, font_properties, font_color):
         for label in self._get_labels():
             label.set_fontproperties(font_properties)
             if font_color is not None:
-                label.set_color(self.font_color)
+                label.set_color(font_color)
 
     def _repr_png_(self):
         from ._mpl_imports import FigureCanvasAgg

yt/visualization/tests/test_plotwindow.py

@@ -912,3 +912,19 @@ def test_invalid_swap_projection():
     slc.set_mpl_projection("Robinson")
     slc.swap_axes()  # should raise mylog.warning and not toggle _swap_axes
     assert slc._has_swapped_axes is False
+
+
+def test_set_font():
+    # simply check that calling the set_font method doesn't raise an error
+    # https://github.com/yt-project/yt/issues/4263
+    ds = fake_amr_ds()
+    slc = SlicePlot(ds, "x", "Density")
+    slc.set_font(
+        {
+            "family": "sans-serif",
+            "style": "italic",
+            "weight": "bold",
+            "size": 24,
+            "color": "blue",
+        }
+    )