[Bugfix] CPP support + OSX build fix. #2943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cphyc
added
bug
infrastructure
neutrinoceros
approved these changes
Oct 14, 2020
Comment on lines
+4
to
+5
| # distutils: extra_compile_args = CPP14_FLAG OMP_ARGS | ||
| # distutils: extra_link_args = CPP14_FLAG OMP_ARGS |
There was a problem hiding this comment.
isn't this meant for #2939 ?
There was a problem hiding this comment.
I'm not sure anymore... Would you be OK with this bit going in this PR? Otherwise, I'll have to rebase, etc... and it will happen anyway in #2939.
There was a problem hiding this comment.
I think it's fine since this is high priority and will I hope we merge #2939 asap too !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR is a companion of #2939 (which is why there are some conversion to C++ happening). It should probably be merged first.