Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: fix compilation errors with Cython 3.0.0b1 (pow return type) #4365

Merged
merged 1 commit into from
Mar 14, 2023
Merged

BLD: fix compilation errors with Cython 3.0.0b1 (pow return type) #4365

merged 1 commit into from
Mar 14, 2023

Conversation

neutrinoceros
Copy link
Member

PR Summary

Fix most of the remaining compilation errors with Cython 3.0.0b1

Address the current top blocking problem in #4355
For context see cython/cython#5299

@neutrinoceros neutrinoceros mentioned this pull request Mar 5, 2023
Closed
15 tasks
@neutrinoceros neutrinoceros added the refactor improve readability, maintainability, modularity label Mar 5, 2023
@neutrinoceros neutrinoceros force-pushed the cython3_type_casting branch from c4068fe to 3f0d2a3 Compare March 5, 2023 23:13
@neutrinoceros neutrinoceros marked this pull request as ready for review March 5, 2023 23:32
chrishavlin
chrishavlin previously approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@chrishavlin chrishavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good -- one naive question: if cython.cpow is introduced in 3.0, does 2.9x just ignore it?

@neutrinoceros
Copy link
Member Author

Great question, I actually hadn't noticed that this decorator was new in Cython 3.0 and now I'm surprised that Cython 0.29 seems just happy to swallow it. I upstreamed your question (see cython/cython#5299 (comment))

@neutrinoceros
Copy link
Member Author

neutrinoceros commented Mar 10, 2023 •
edited
Loading

So, this decorator was added to Cython 0.29.x as a no-op for backward compatibility, see Cython's changelog
It does require Cython>=0.29.33, so I'll need to bump the requirement explicitly.

chrishavlin
chrishavlin previously approved these changes Mar 11, 2023
View reviewed changes
neutrinoceros
neutrinoceros commented Mar 11, 2023
View reviewed changes
.github/workflows/wheels.yaml
@@ -84,7 +84,7 @@ jobs:
- name: Install build time dependencies
shell: bash
run: |
python -m pip install "Cython>=0.29.21,<3.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forced-pushed again because I forgot to update this line too

@neutrinoceros
Copy link
Member Author

Can we merge this to ease up work on the last compilation error ?
@chrishavlin @matthewturk ?

@chrishavlin
Copy link
Contributor

Can we merge this to ease up work on the last compilation error ?

OK by me -- I assume bumping the minimum version of cython from 0.29.21 to 0.29.33 shouldn't be an issue, right? seems totally reasonable to me...

@matthewturk ?

@matthewturk matthewturk merged commit 2fb4fd8 into yt-project:main Mar 14, 2023
@neutrinoceros neutrinoceros deleted the cython3_type_casting branch March 14, 2023 10:39
@neutrinoceros neutrinoceros added the build related to the build process label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrishavlin chrishavlin chrishavlin approved these changes

Assignees
No one assigned
Labels
build related to the build process refactor improve readability, maintainability, modularity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neutrinoceros @chrishavlin @matthewturk