Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPG bug fix #1109

Merged
merged 3 commits into from
Nov 22, 2017
Merged

GPG bug fix #1109

merged 3 commits into from
Nov 22, 2017

Conversation

elmobp
Copy link
Contributor

@elmobp elmobp commented Nov 19, 2017

Fixes #1082

@laf laf self-assigned this Nov 20, 2017
@laf
Copy link
Contributor

laf commented Nov 20, 2017

Tested fine.

I do get prompted for the passphrase again when loading oxidized but from what I've found, this is because of gpg2: ueno/ruby-gpgme#11

@laf laf merged commit da89235 into ytti:master Nov 22, 2017
@mikenowak
Copy link
Contributor

Unfortunately this breaks the csv processing altogether.

I, [2017-11-23T05:40:58.509504 #5355]  INFO -- : Oxidized starting, running as pid 5355
I, [2017-11-23T05:40:58.639560 #5355]  INFO -- : lib/oxidized/nodes.rb: Loading nodes
E, [2017-11-23T05:40:58.641738 #5355] ERROR -- : node {:name=>"/root/.config/oxidized/router.db", :model=>nil, :username=>nil, :password=>nil, :vars=>{:ssh_port=>nil}} is not resolvable, raised Resolv::ResolvError with message 'no address for /root/.config/oxidized/router.db'
I, [2017-11-23T05:40:58.641831 #5355]  INFO -- : lib/oxidized/nodes.rb: Loaded 0 nodes
F, [2017-11-23T05:40:58.641938 #5355] FATAL -- : Oxidized crashed, crashfile written in /root/.config/oxidized/crash
source returns no usable nodes
/var/lib/gems/2.3.0/gems/oxidized-0.21.0/lib/oxidized/core.rb:15:in `initialize': source returns no usable nodes (Oxidized::Core::NoNodesFound)
	from /var/lib/gems/2.3.0/gems/oxidized-0.21.0/lib/oxidized/core.rb:4:in `new'
	from /var/lib/gems/2.3.0/gems/oxidized-0.21.0/lib/oxidized/core.rb:4:in `new'
	from /var/lib/gems/2.3.0/gems/oxidized-0.21.0/lib/oxidized/cli.rb:12:in `run'
	from /var/lib/gems/2.3.0/gems/oxidized-0.21.0/bin/oxidized:9:in `<top (required)>'
	from /usr/local/bin/oxidized:22:in `load'
	from /usr/local/bin/oxidized:22:in `<main>'

@laf
Copy link
Contributor

laf commented Nov 23, 2017

@mikenowak thanks for spotting that. I've just pushed #1113 which fixes this.

@elmobp I think #1113 now breaks gpg support again though, I had a play around trying to get it working but couldn't figure it out - would you mind taking a look?

@elmobp
Copy link
Contributor Author

elmobp commented Nov 24, 2017

Ill have a poke over the weekend!

@laf
Copy link
Contributor

laf commented Nov 27, 2017

@elmobp thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants