Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc-c++ needed in oxidized-web 0.10.2 #1369

Merged
merged 1 commit into from
Jun 7, 2018
Merged

gcc-c++ needed in oxidized-web 0.10.2 #1369

merged 1 commit into from
Jun 7, 2018

Conversation

Atroskelis
Copy link
Contributor

Oxidized-web 0.10.2 requires gcc-c++ to be able to install the gem in Centos 7. Updated docs.

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

Oxidized-web 0.10.2 requires gcc-c++ to be able to install the gem in Centos 7. Updated docs.
@codecov-io
Copy link

codecov-io commented Jun 7, 2018

Codecov Report

Merging #1369 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1369      +/-   ##
==========================================
+ Coverage   62.17%   62.31%   +0.14%     
==========================================
  Files          28       28              
  Lines        1388     1388              
==========================================
+ Hits          863      865       +2     
+ Misses        525      523       -2
Impacted Files Coverage Δ
lib/oxidized/output/git.rb 17.96% <0%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3974501...7225a8e. Read the comment docs.

@wk
Copy link
Contributor

wk commented Jun 7, 2018

This appears to be required for charlock_holmes as it includes some C++ components.

@wk wk merged commit 63c5ff8 into ytti:master Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants