Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README.md #1590

Merged
merged 4 commits into from
Oct 14, 2018
Merged

Updated README.md #1590

merged 4 commits into from
Oct 14, 2018

Conversation

thermionic
Copy link
Contributor

@thermionic thermionic commented Oct 12, 2018

added enabling Universe for Ubuntu 18.04

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

added enabling Universe for Ubuntu 18.04
@codecov-io
Copy link

codecov-io commented Oct 12, 2018

Codecov Report

Merging #1590 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1590      +/-   ##
=========================================
- Coverage   62.54%   62.5%   -0.04%     
=========================================
  Files          30      30              
  Lines        1495    1491       -4     
=========================================
- Hits          935     932       -3     
+ Misses        560     559       -1
Impacted Files Coverage Δ
lib/oxidized/output/git.rb 17.32% <0%> (-0.65%) ⬇️
lib/oxidized/input/ssh.rb 54.73% <0%> (-0.48%) ⬇️
lib/oxidized/node.rb 71.32% <0%> (-0.2%) ⬇️
lib/oxidized/hook/githubrepo.rb 75% <0%> (+1.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f633a3...9b0138c. Read the comment docs.

Copy link
Contributor

@laf laf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wk added 2 commits October 14, 2018 18:29
Clarify Ubuntu and Debian installation instructions
Correct sentence formulation
@wk wk merged commit 9e4d060 into ytti:master Oct 14, 2018
@wk
Copy link
Contributor

wk commented Oct 14, 2018

Thanks!

RobbFromIT pushed a commit to RobbFromIT/oxidized that referenced this pull request Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants