Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a missing dependency for debian #1684

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Adding a missing dependency for debian #1684

merged 1 commit into from
Jan 23, 2019

Conversation

XaaT
Copy link
Contributor

@XaaT XaaT commented Jan 17, 2019

Add g++ (mandatory to compile extensions used with oxidized-web compilation through gem install)

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

Add g++ (mandatory to compile extensions used with oxidized-web compilation through gem install)
@codecov-io
Copy link

codecov-io commented Jan 17, 2019

Codecov Report

Merging #1684 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1684     +/-   ##
========================================
+ Coverage   62.49%   62.6%   +0.1%     
========================================
  Files          30      30             
  Lines        1493    1492      -1     
========================================
+ Hits          933     934      +1     
+ Misses        560     558      -2
Impacted Files Coverage Δ
lib/oxidized/node.rb 71.32% <0%> (-0.2%) ⬇️
lib/oxidized/output/git.rb 18.25% <0%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2bfb98...351b32a. Read the comment docs.

@XaaT
Copy link
Contributor Author

XaaT commented Jan 17, 2019

Without g++

root@oxidized:~# gem install oxidized-web
Building native extensions. This could take a while...
ERROR: Error installing oxidized-web:
ERROR: Failed to build gem native extension.

current directory: /var/lib/gems/2.3.0/gems/charlock_holmes-0.7.6/ext/charlock_holmes

/usr/bin/ruby2.3 -r ./siteconf20190117-1206-1m9m8s2.rb extconf.rb
checking for main() in -licui18n... yes
checking for main() in -licui18n... yes
checking for unicode/ucnv.h... yes
checking for main() in -lz... yes
checking for main() in -licuuc... yes
checking for main() in -licudata... yes
creating Makefile

To see why this extension failed to compile, please check the mkmf.log which can be found here:

/var/lib/gems/2.3.0/extensions/x86_64-linux/2.3.0/charlock_holmes-0.7.6/mkmf.log

current directory: /var/lib/gems/2.3.0/gems/charlock_holmes-0.7.6/ext/charlock_holmes
make "DESTDIR=" clean

current directory: /var/lib/gems/2.3.0/gems/charlock_holmes-0.7.6/ext/charlock_holmes
make "DESTDIR="
compiling converter.c
compiling encoding_detector.c
compiling ext.c
compiling transliterator.cpp
make: g++ : commande introuvable
Makefile:231 : la recette pour la cible « transliterator.o » a échouée
make: *** [transliterator.o] Erreur 127

make failed, exit code 2

Gem files will remain installed in /var/lib/gems/2.3.0/gems/charlock_holmes-0.7.6 for inspection.
Results logged to /var/lib/gems/2.3.0/extensions/x86_64-linux/2.3.0/charlock_holmes-0.7.6/gem_make.out

"commande introuvable" = command not found

@wk
Copy link
Contributor

wk commented Jan 23, 2019

Thanks! It seems that while the CentOS instructions were already updated (with the equivalent gcc-c++ package), the Ubuntu instructions were not. This is indeed a dependency for charlock_holmes / ICU.

@wk wk merged commit 6b95cee into ytti:master Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants