Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GcomBNPS: allow any max length for username/password #2022

Merged
merged 2 commits into from
Jan 29, 2020
Merged

Conversation

freddy36
Copy link
Contributor

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • User-visible changes appended to CHANGELOG.md

Description

Allow any max length for username/password in GcomBNPS model (max length varies between software versions)

@freddy36 freddy36 changed the title Patch 3 GcomBNPS: allow any max length for username/password Jan 28, 2020
@codecov-io
Copy link

codecov-io commented Jan 28, 2020

Codecov Report

Merging #2022 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2022   +/-   ##
=======================================
  Coverage   63.32%   63.32%           
=======================================
  Files          30       30           
  Lines        1497     1497           
=======================================
  Hits          948      948           
  Misses        549      549

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 105f565...c9c6ba1. Read the comment docs.

@wk
Copy link
Contributor

wk commented Jan 29, 2020

Thanks for this! Pulling it in.

@wk wk merged commit 9b3e277 into ytti:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants