Allow online (https) CSS in markdown-pdf.styles

[vimtaai]

It would be nice to be able to include online CSS without the need to have a local copy.

"markdown-pdf.styles": [
  "https://unpkg.com/mdss"
]

Sadly this is not working.

[yzane]

"markdown-pdf.styles": [
  "https://unpkg.com/mdss"
]

The CSS is applied correctly in JPG and PNG, but there is a problem with the PDF.
For now, I will release it as a known issue.

[Haenkos]

A missing semicolon in the '@media print' rule of the linked stylesheet at https://unpkg.com/mdss is causing problems with PDF-export (paragraph text not showing). At the first instance of the '@media print' rule, a semicolon is missing after the 'body{color:#000}' attribute. Adding a semicolon fixes the problem of paragraph text not showing. See also issue #240 .

[vimtaai]

A missing semicolon in the '@media print' rule of the linked stylesheet at https://unpkg.com/mdss is causing problems with PDF-export (paragraph text not showing). At the first instance of the '@media print' rule, a semicolon is missing after the 'body{color:#000}' attribute. Adding a semicolon fixes the problem of paragraph text not showing. See also issue #240 .

This issue is for the mdss package (that I maintain), not this one. I don't think the problem is the missing semicolon (the CSS is syntaxically OK), but the lazy loading of fonts in the print preview of Chromium browsers. It is a known issue that fonts only show up on the second rendering in the print preview dialog if they were loaded from a CDN.

[Haenkos]

Ah, okay my bad. I'm still pretty inexperienced. Putting a semicolon at the mentioned place did make some black paragraph text show up so i thought i had found something there. :-)

Should i delete my previous comment (and subsequently this one), or is it worth leaving it up for whatever reason?

[vimtaai]

@Haenkos No problem 🙂 Your problem was probably solved by reloading the print preview rather than the added semicolon.

As for the comment I think it can stay. 🙂