Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can not work with lastest VS Code version #77

Closed
zhiqunliu opened this issue Apr 24, 2018 · 10 comments
Closed

can not work with lastest VS Code version #77

zhiqunliu opened this issue Apr 24, 2018 · 10 comments
Milestone

Comments

@zhiqunliu
Copy link

ERROR:
Command failed: npm rebuild puppeteer
C:\Users\admin.vscode\extensions\yzane.markdown-pdf-1.0.1\node_modules\puppeteer\install.js:80
let progressBar = null;
^^^

SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
at exports.runInThisContext (vm.js:53:16)
at Module._compile (module.js:373:25)
at Object.Module._extensions..js (module.js:416:10)
at Module.load (module.js:343:32)
at Function.Module._load (module.js:300:12)
at Function.Module.runMain (module.js:441:10)
at startup (node.js:139:18)
at node.js:968:3

npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "rebuild" "puppeteer"
npm ERR! node v4.4.3
npm ERR! npm v2.15.1
npm ERR! code ELIFECYCLE
npm ERR! [email protected] install: node install.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] install script 'node install.js'.
npm ERR! This is most likely a problem with the puppeteer package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! node install.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs puppeteer
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR! npm owner ls puppeteer
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR! C:\Users\admin.vscode\extensions\yzane.markdown-pdf-1.0.1\npm-debug.log

VS Code version:
Version 1.22.2
Commit 3aeede733d9a3098f7b4bdc1f66b63b0f48c1ef9
Date 2018-04-12T16:38:45.278Z
Shell 1.7.12
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

yzane added a commit that referenced this issue Apr 24, 2018
@yzane
Copy link
Owner

yzane commented Apr 24, 2018

Please download Markdown PDF ver1.0.2 and try it.

@FereX98
Copy link

FereX98 commented Apr 25, 2018

I've downloaded the latest version (1.0.2) but it still doesn't work. There's a notification saying "Installing Puppeteer" like forever. Tried downloading with ShadowSocks on but no luck.

@gitto01
Copy link

gitto01 commented Apr 25, 2018

Same here (version 1.0.2). There's a notification saying "Installing Puppeteer" like forever.

@gitto01
Copy link

gitto01 commented Apr 25, 2018

I apologize, please ignore my last comment. It takes a long time to install Puppeteer but it works. Sorry again.

@yzane
Copy link
Owner

yzane commented Apr 25, 2018

@gitto01 Thank you for the report.

"Installing Puppeteer" downloads Chromium, but It takes time because the size of Chromium is about 300 MB.

@yzane
Copy link
Owner

yzane commented Apr 25, 2018

If you do not solve with Markdown PDF ver1.0.2 please do the following.

  1. Set the markdown-pdf.executablePath option
    See the README for markdown-pdf.executablePath option setting

  2. Restart the Visual Studio Code

@FereX98
Copy link

FereX98 commented Apr 26, 2018

@yzane I followed your instructions, changed markdown-pdf.executablePath to the location of my chrome browser executable, and it finally works! Thank you very much!

@yzane
Copy link
Owner

yzane commented Apr 26, 2018

@FereX98 Thank you for the report.

@yzane yzane added this to the 1.0.2 milestone Apr 28, 2018
@yzane yzane closed this as completed Apr 30, 2018
@neyangg
Copy link

neyangg commented Jun 11, 2018

I searched everywhere, however found no solution about setting the "markdown-pdf.executablePath" option on MAC, any one could help?

I have tried "/Users/neyan/Applications/Google Chrome.app/" , but failed

@eprendre
Copy link

@neyangg I finally figured out the correct path, you have to pick the one inside Google Chrome.app.

"markdown-pdf.executablePath":"/Applications/Google Chrome.app/Contents/MacOS/Google Chrome"

tat3 pushed a commit to tat3/vscode-markdown-pdf-2 that referenced this issue Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants