Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to specify the plantuml delimiter #104

Merged

Conversation

andre-stoesel
Copy link
Contributor

I created this pull request to solve the problem from issue #92.

The export of gitlab flavored markdown file with plantuml drawings work fine, if the opening delimiter is set to ```plantuml and the closing delimiter is set to ```.

@andre-stoesel andre-stoesel changed the base branch from master to develop August 30, 2018 15:09
@ChrisTuckerNM
Copy link

Approved yet? Implemented?

@paussems
Copy link

paussems commented Dec 6, 2018

Would be nice if this patch gets merged

@bvella
Copy link

bvella commented Dec 26, 2018

I am using this patch to be able to convert markdown files to pdf that use gitlab style diagrams, i.e. code block with plantuml language. Can this be merged or some feedback provided? I hate to have to ask developers to manually patch the plugin to be able to export a pdf

@PetrGasparik
Copy link

PetrGasparik commented Mar 13, 2019

Please merge this patch.

BTW I tried to apply it by changing c:\Users<user>.vscode\extensions\yzane.markdown-pdf-1.2.0 foles and it didn!t help. I understand that I need markdown-it-plantuml plugin but how to get it? VSCode for windows

@anorm
Copy link

anorm commented May 9, 2019

I would also love to see this patch merged. Using vscode with "PlantUML" jebbs.plantuml and "Markdown PDF" yzane.markdown-pdf extensions makes for a perfect combo.

@yzane yzane added this to the 1.2.1 milestone Sep 7, 2019
@patmuk
Copy link

patmuk commented Sep 17, 2019

Please release 1.2.1 as soon as possible, this is a highly desired feature!

@yzane yzane merged commit 0044e46 into yzane:develop Sep 22, 2019
@yzane
Copy link
Owner

yzane commented Sep 22, 2019

Thanks for your PR!

tat3 pushed a commit to tat3/vscode-markdown-pdf-2 that referenced this pull request Sep 4, 2022
…om-delimiter

Option to specify the plantuml delimiter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants