Skip to content

Commit

Permalink
Use clang 17 everywhere
Browse files Browse the repository at this point in the history
  • Loading branch information
zakaria-fadli-netatmo committed Nov 10, 2024
1 parent 31ecfa2 commit c1bf1e6
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- uses: actions/checkout@v3

- name: Install other
run: sudo ./first_setup.sh
run: ./first_setup.sh

configure:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -46,6 +46,7 @@ jobs:
needs: configure
steps:
- uses: actions/checkout@v3

- name: clang-tidy
run: make clang-tidy

Expand Down
4 changes: 2 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ file(GLOB_RECURSE
############################################################

# Add clang-tidy to the project
find_program(CLANG_TIDY_EXE NAMES "clang-tidy-20")
find_program(CLANG_TIDY_EXE NAMES "clang-tidy-17")

if(CLANG_TIDY_EXE)
message(STATUS "clang-tidy found: ${CLANG_TIDY_EXE}")
Expand Down Expand Up @@ -164,7 +164,7 @@ endif()

# Add clang-format to the project only if version >= 17
# using --version
find_program(CLANG_FORMAT "clang-format-20")
find_program(CLANG_FORMAT "clang-format-17")

if(CLANG_FORMAT)
message(STATUS "clang-format found: ${CLANG_FORMAT}")
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

#### Build system
- CMake 3.19 or later (to be able to use CMakePresets)
- C++ compiler with C++23 support (Recommended clang-17+, The CI uses clang-20)
- C++ compiler with C++23 support (clang 17)
- ninja-build

#### Static analyzes
Expand Down
2 changes: 1 addition & 1 deletion first_setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ apt-get install -y $PACKAGES
# Install LLVM
wget https://apt.llvm.org/llvm.sh
chmod +x llvm.sh
yes | ./llvm.sh 17 all
yes | sudo ./llvm.sh 17 all

0 comments on commit c1bf1e6

Please sign in to comment.