Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set HttpTokens to optional #579

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

hughcapet
Copy link
Collaborator

This commit forces MetadataOptions->HttpTokens to always be set to 'optional' by senza, as we want to still be able to use IMDSv1, while base AMIs enforce v2 and ebs packer still doesn't allow this to be redefined.

@hughcapet hughcapet force-pushed the fix/force-metadataoptions-httptokens-optional branch 5 times, most recently from 8449bfd to 02b8b6f Compare February 23, 2023 10:19
@hughcapet hughcapet force-pushed the fix/force-metadataoptions-httptokens-optional branch from 02b8b6f to 08716ee Compare February 28, 2023 15:51
This commit forces MetadataOptions->HttpTokens to always be set to
'optional' by senza, as we want to still be able to use IMDSv1, while
base AMIs enforce v2 and ebs packer still doesn't allow this to be
redefined.
@hughcapet hughcapet force-pushed the fix/force-metadataoptions-httptokens-optional branch from 08716ee to 60f771d Compare March 27, 2023 04:48
@hughcapet hughcapet marked this pull request as ready for review March 27, 2023 11:46
@hughcapet hughcapet requested a review from Jan-M March 27, 2023 11:46
@Jan-M
Copy link
Contributor

Jan-M commented Mar 27, 2023

👍

1 similar comment
@hughcapet
Copy link
Collaborator Author

👍

@hughcapet hughcapet merged commit 0134404 into master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants