Improve validation for Rule 240 #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Simplify code * Add a fix when `boolean` enums are validated * Add a type check for enum value types and a property type * Fix variable shadowing problem * Make `extensibleEnum` extension return `Any` instead of `String`
|
@tkrop this PR fixes the problem with the Rule 240 you've mentioned |
Codecov Report
@@ Coverage Diff @@
## master #1245 +/- ##
=========================================
Coverage 87.62% 87.62%
Complexity 85 85
=========================================
Files 69 69
Lines 978 978
Branches 71 71
=========================================
Hits 857 857
Misses 84 84
Partials 37 37 Continue to review full report at Codecov.
|
tkrop
reviewed
May 31, 2021
server/zally-core/src/main/kotlin/org/zalando/zally/core/util/OpenApiUtil.kt
Show resolved
Hide resolved
server/zally-core/src/main/kotlin/org/zalando/zally/core/util/OpenApiUtil.kt
Show resolved
Hide resolved
| validatePrimitiveSchemas(context) + validateAllProperties(context) | ||
|
|
||
| private fun validateAllProperties(context: Context): List<Violation> = context.api.getAllProperties() | ||
| .filter { it.value.type == "string" } |
There was a problem hiding this comment.
Didn't we need to check independent of property type for value definitions? Currently, it looks as if they are just not checked. However, I must confess, I have no idea how numbers 1, 2, and true, false would behave in this context.
|
👍 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
booleanenums are validatedextensibleEnumextension returnAnyinstead ofStringRelated to #1221 and #1183