-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FHE Regex Pattern Matching Engine #278
Conversation
first request for this PR: squash in a single commit and follow the commit message format, in that case it should be
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still need to review a bit more deeply I looked good from what i've seen so far, I've made some comments.
Not quite sure if you want the example implementation to be under tfhe/src directly (how it is in this PR atm), or to have it be more of an external dependency (like how I initially had set it up in a separate repo). Let me know.
Yes we would prefer the implementation to be more separated from the lib.
Normally you should be able to have all your code under a sub folder of the examples
folder
You could take at look at this other bounty where its organized in the example folder #283
57bbbf3
to
f7ecbc2
Compare
I addressed each comment that's been left here so far. I moved the example implementation from |
0f4c18c
to
5e58c34
Compare
closes zama-ai/bounty-program#38 |
this includes a tutorial and an example implementation for the regex bounty
Most important locations:
tfhe/docs/regex/tutorial.md
tfhe/src/regex/..
Not quite sure if you want the example implementation to be under
tfhe/src
directly (how it is in this PR atm), or to have it be more of an external dependency (like how I initially had set it up in a separate repo). Let me know.I might still want to add a
Further work
section at the end of the tutorial, and to add some comments to the code. But I think it's best to open this PR now to get the final review process started.To run the included tests run:
cargo test --release --features=x86_64,integer --example regex_engine
.