Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cookies on WebClient. #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

binarymist
Copy link

If ClientApi.PostToUrl is not generic enough for main stream consumption, consumers could make an extension method out of it.
Access to the WebClient's headers are required in ClientApi.PostToUrl
Currently consumers have to maintain this locally. Once this is included, consumers can then depend on the NuGet package instead.

@gmaran23
Copy link
Collaborator

Hi, Thanks for the pull request. It took me a little while to get around this pull request.

  1. Do you have a sample of how the public method ClientApi.PostToUrl can come in handy for the api consumers?
  2. What is the use case for this method?

It seems like in order to support this method ClientApi.PostToUrl (and also send some cookie information along the request) we need to restructure the IWebClient interface rather than directly modifying the SystemWebClient class.

@binarymist
Copy link
Author

I no longer have access to this .NET environment, and because it's been so long, is no longer fresh in my head. I've passed this onto my client that I was working for at the time. My client will hopefully provide feedback soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants