First version of sbom output #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Racer159
requested review from
mike-winberry,
Noxsios,
Madeline-UX,
JasonvanBrackel and
RothAndrew
as code owners
jeff-mccoy
previously approved these changes
Dec 7, 2022
There was a problem hiding this comment.
lgtm. Overall this will be much better once it's all in the UI and we no longer have this out-of-band weird viewer thing happening. Also the flow of "press enter when done" is interesting and something we may look at for the Zarf UI as well as now it just requires aborting the command.
YrrepNoj
suggested changes
Dec 7, 2022
jeff-mccoy
approved these changes
Dec 8, 2022
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
## Description Add new flags to output SBOM files into specified directories **AND** change the sbom inspect behavior to also open the web browser automatically ## Related Issue Fixes #1075 ## Type of change <!-- Please delete options that are not relevant --> - [X] New feature (non-breaking change which adds functionality) ## Checklist before merging - [X] Tests have been added/updated as necessary (add the `needs-tests` label) - [x] Documentation has been updated as necessary (add the `needs-docs` label)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new flags to output SBOM files into specified directories AND change the sbom inspect behavior to also open the web browser automatically
Related Issue
Fixes #1075
Type of change
Checklist before merging
needs-testslabel)needs-docslabel)