800. Add sbom section to deploy configure/review #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ml instead of extracting it. Create api/packages sbom to rextract and launch sbom (first iteration need team input. Update front end to request the sbom information and display a link to launch (ui still in progress).
3 tasks
✅ Deploy Preview for zarf-docs canceled.
|
✅ Deploy Preview for zarf-docs canceled.
|
|
@Racer159 and @Madeline-UX we will likely need to tag up and go over some things on this as far as the ux flow. I have a "basic" working pattern right now but am working on making it much better, but will need to discuss some of verbiage and file location patterns once I have explored serving the sbom files. |
…color after the unicorn-ui changes to list. Update ui build-providence to have the sbom url and a button to copy to clipboard. Create ui CopyToClipBoard component. Remove launch behavior from api start, sbom and ui api. Created new ripple global class in ui app.css for use in non-unicorn-ui components and created issue in UUI to port over and potentially implement the ripple as a component.
…remove zarf-sbom folder, ExtractSBOM now just looks for a path param instead of requiring the entire package. Update api start.go with get sbom/{path} and delete /sbom paths. Update ui api with the correct get and delete methods for sbom. Update ui BuildProvidence component with proper copy and made the link stand out per madeline. Update ui /packages layout to remove zarf-sbom folder on destroy.
…r and ensured that the folder is empty before unpacking a new sbom tar also removed the map store for sboms as one sbom should only be unpacked at a time during deployment to match cli behavior. Update ui packages layout to clear the pkgSbomStore on destroy. Update build-providence to use the pkgSbomStore if it exists and to fetch otherwise. Update copy-to-clipboard with title text.
mike-winberry
requested review from
Racer159,
Noxsios,
jeff-mccoy and
YrrepNoj
as code owners
…ing the sbom-viewer path. Update build providence sbom path link to open the sbom-viewer in a new tab and added warning that the folder.
Screen.Recording.2023-05-19.at.11.01.24.AM.mov |
|
A few tweaks:
|
…new design and adding the view sbom button to the section
…re is a valid sbom url.
|
@Racer159 @Madeline-UX Screen.Recording.2023-05-20.at.8.30.59.PM.mov |
Madeline-UX
previously approved these changes
May 22, 2023
Racer159
requested changes
May 22, 2023
Racer159
approved these changes
May 22, 2023
Noxsios
deleted the
800-add-sbom-section-to-configure-page-in-deployment-wizard
branch
mike-winberry
added a commit
that referenced
this pull request
Jun 12, 2023
## Description #800 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [ ] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed --------- Co-authored-by: Wayne Starr <[email protected]> Co-authored-by: Wayne Starr <[email protected]>
mike-winberry
added a commit
that referenced
this pull request
Jun 12, 2023
## Description #800 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [ ] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed --------- Co-authored-by: Wayne Starr <[email protected]> Co-authored-by: Wayne Starr <[email protected]>
mike-winberry
added a commit
that referenced
this pull request
Jun 12, 2023
## Description #800 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [ ] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed --------- Co-authored-by: Wayne Starr <[email protected]> Co-authored-by: Wayne Starr <[email protected]>
mike-winberry
added a commit
that referenced
this pull request
Jun 12, 2023
## Description #800 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [ ] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed --------- Co-authored-by: Wayne Starr <[email protected]> Co-authored-by: Wayne Starr <[email protected]>
mike-winberry
added a commit
that referenced
this pull request
Jun 12, 2023
## Description #800 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [ ] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed --------- Co-authored-by: Wayne Starr <[email protected]> Co-authored-by: Wayne Starr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#800
Type of change
Checklist before merging