refactor: action retry to use go-retry #2868
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philip Laine <[email protected]>
phillebaba
force-pushed
the
fix/action-retry
branch
from
aee71be to
8bd06ce
Compare
Signed-off-by: Philip Laine <[email protected]>
phillebaba
force-pushed
the
fix/action-retry
branch
from
8bd06ce to
4c03b75
Compare
phillebaba
commented
Aug 12, 2024
| spinner.Updatef("Waiting for \"%s\" %s", cmdEscaped, timeoutStr) | ||
| }), | ||
| ) | ||
| if actionCtx.Err() != nil { |
There was a problem hiding this comment.
This will also happen on context cancel so need another way of checking for timeout. An option is to use with cause.
phillebaba
commented
Aug 12, 2024
| // Try running the command and continue the retry loop if it fails. | ||
| if out, err = actionRun(ctx, actionDefaults, cmd, actionDefaults.Shell, spinner); err != nil { | ||
| // If an output variable is defined, set it. | ||
| for _, v := range action.SetVariables { |
There was a problem hiding this comment.
Should this be retried? It it seems like this was done because implementing it would have been difficult in the old code. It seems a lot smarter to only retry the action on errors and not the setting on variables as I assume the output variables will be the same every time the actions run.
|
Before merging we should add tests to the Run function to validate the error output for the different failure modes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change replaces the custom retry logic with using go-retry. It simplifies legibility a lot by removing use of labels to break out of the outer loop.
Related Issue
Depends on #2856
Checklist before merging