Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log correct size with units during image pull #3440

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

AustinAbro321
Copy link
Contributor

Description

Fixes #3439

Checklist before merging

Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321 AustinAbro321 requested review from a team as code owners January 27, 2025 17:59
Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 415a756
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6797d4563f022d0008d64b25

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 48.57143% with 18 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager/images/pull.go 48.57% 14 Missing and 4 partials ⚠️
Files with missing lines Coverage Δ
src/internal/packager/images/pull.go 54.66% <48.57%> (-0.14%) ⬇️

@AustinAbro321 AustinAbro321 changed the title fix: display correct size with units during image pull fix: log correct size with units during image pull Jan 27, 2025
mkcp
mkcp previously approved these changes Jan 27, 2025
Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nonblocking nit, LGTM

@@ -397,6 +391,32 @@ func CleanupInProgressLayers(ctx context.Context, img v1.Image, cacheDirectory s
return eg.Wait()
}

func getSizeOfImage(img v1.Image) (int64, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tidy 👍

src/internal/packager/images/pull.go Outdated Show resolved Hide resolved
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit af91772 Jan 27, 2025
26 checks passed
@AustinAbro321 AustinAbro321 deleted the fix-image-size-log branch January 27, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image size message is misleading
2 participants