Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TLS cert in Big Bang example #455

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Update TLS cert in Big Bang example #455

merged 1 commit into from
Apr 22, 2022

Conversation

RothAndrew
Copy link
Contributor

@RothAndrew RothAndrew commented Apr 21, 2022 •
edited
Loading

Description

Update the TLS cert in the Big Bang example (it was expired)

Related Issue

none

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist before merging

  • Tests have been added/updated as necessary (add the needs-tests label)
  • Documentation has been updated as necessary (add the needs-docs label)
  • An ADR has been written as necessary (add the needs-adr label) [ 1 2 3 ]
  • (Optional) Changes have been linted locally with golangci-lint. (NOTE: We haven't turned on lint checks in the pipeline yet so linting may be hard if it shows a lot of lint errors in places that weren't touched by changes. Thus, linting is optional right now.)

@RothAndrew RothAndrew requested a review from YrrepNoj April 21, 2022 19:25
@RothAndrew RothAndrew self-assigned this Apr 21, 2022
@RothAndrew RothAndrew enabled auto-merge (squash) April 21, 2022 19:26
jeff-mccoy
jeff-mccoy approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cert expires in < 60 days, but LGTM

Screen Shot 2022-04-21 at 2 31 45 PM

@RothAndrew
Copy link
Contributor Author

#FireTommy

@RothAndrew RothAndrew merged commit 4525d46 into master Apr 22, 2022
@RothAndrew RothAndrew deleted the RothAndrew-patch-1 branch April 22, 2022 02:32
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
@RothAndrew
Update TLS cert in Big Bang example (#455)
9fb943e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-mccoy jeff-mccoy jeff-mccoy approved these changes

@YrrepNoj YrrepNoj Awaiting requested review from YrrepNoj

Assignees

@RothAndrew RothAndrew

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RothAndrew @jeff-mccoy