Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small terminal UI improvements #670

Merged
merged 4 commits into from
Aug 12, 2022
Merged

Small terminal UI improvements #670

merged 4 commits into from
Aug 12, 2022

Conversation

jeff-mccoy
Copy link
Contributor

@jeff-mccoy jeff-mccoy commented Aug 12, 2022 •
edited
Loading

Related Issue

Fixes #634
Fixes #635

@jeff-mccoy
Copy link
Contributor Author

Screen Shot 2022-08-12 at 3 31 28 AM

@jeff-mccoy
Copy link
Contributor Author

Screen Shot 2022-08-12 at 11 55 29 AM

@jeff-mccoy
Copy link
Contributor Author

Screen Shot 2022-08-12 at 12 44 30 PM

@jeff-mccoy jeff-mccoy requested a review from Racer159 August 12, 2022 17:46
Racer159
Racer159 requested changes Aug 12, 2022
View reviewed changes
src/internal/helm/chart.go Outdated Show resolved Hide resolved
src/internal/git/push.go Outdated Show resolved Hide resolved
src/internal/message/spinner.go Show resolved Hide resolved
src/internal/sbom/viewer/styles.css Show resolved Hide resolved
@jeff-mccoy jeff-mccoy requested a review from Racer159 August 12, 2022 22:40
Racer159
Racer159 approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, though wouldn't that still leave double lines with spinner.Success() then spinner.Stop()?

@jeff-mccoy jeff-mccoy enabled auto-merge (squash) August 12, 2022 23:07
@jeff-mccoy jeff-mccoy merged commit a062aa9 into master Aug 12, 2022
@jeff-mccoy jeff-mccoy deleted the terminal-ui-cleanup branch August 12, 2022 23:15
@jeff-mccoy jeff-mccoy mentioned this pull request Aug 13, 2022
Merged
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
@jeff-mccoy
Small terminal UI improvements (#670)
3fa24e1 
* small terminal UI improvements
* deal with docker scratch images
* sans-serif so wayne stops judging me
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Racer159 Racer159 Racer159 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SBOM Viewer may display "undefined" if no data could be found Extra line breaks displayed in Zarf v0.20.0
2 participants
@jeff-mccoy @Racer159