Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve madeline feedback on examples main page #695

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Resolve madeline feedback on examples main page #695

merged 2 commits into from
Aug 24, 2022

Conversation

Racer159
Copy link
Contributor

Description

This addresses some feedback from @Madeline-UX on the examples page in coordination with defenseunicorns/zarf-docs#47

Related Issue

None

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist before merging

  • (Optional) Changes have been linted locally with golangci-lint. (NOTE: We haven't turned on lint checks in the pipeline yet so linting may be hard if it shows a lot of lint errors in places that weren't touched by changes. Thus, linting is optional right now.)

@jeff-mccoy
Copy link
Contributor

Defer to @Madeline-UX

@Racer159 Racer159 merged commit f8287dd into master Aug 24, 2022
@Racer159 Racer159 deleted the resolve-madeline-feedback branch August 24, 2022 23:53
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
@Racer159
Resolve madeline feedback on examples main page (#695)
81ba52a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madeline-UX Madeline-UX Madeline-UX approved these changes

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

@YrrepNoj YrrepNoj Awaiting requested review from YrrepNoj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Racer159 @jeff-mccoy @Madeline-UX