Add package remove & package list to cli #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YrrepNoj
force-pushed
the
uninstall-the-things-from-master
branch
from
d2d9d20 to
1dd1f5c
Compare
jeff-mccoy
reviewed
Sep 15, 2022
docs/4-user-guide/1-the-zarf-cli/100-cli-commands/zarf_package_list.md
Outdated
Show resolved
Hide resolved
jeff-mccoy
reviewed
Sep 15, 2022
docs/4-user-guide/1-the-zarf-cli/100-cli-commands/zarf_package_uninstall.md
Show resolved
Hide resolved
jeff-mccoy
reviewed
Sep 15, 2022
jeff-mccoy
reviewed
Sep 15, 2022
jeff-mccoy
reviewed
Sep 15, 2022
jeff-mccoy
reviewed
Sep 15, 2022
Closed
jeff-mccoy
reviewed
Sep 16, 2022
docs/4-user-guide/1-the-zarf-cli/100-cli-commands/zarf_package_remove.md
Show resolved
Hide resolved
jeff-mccoy
reviewed
Sep 16, 2022
jeff-mccoy
reviewed
Sep 16, 2022
|
There were quite a few lint/small issues, think you should probably comb through this one a bit more in the AM. I started to use the remove command in test since I couldn't see a test for it. But there may be a bug: when you pass a component list but don't remove all components, the secret seems to be deleted anyway. Also think the list command should use the table printer for conistency: https://github.com/pterm/pterm/tree/master/_examples/table. |
fix bug with replacing deployed package secrets
|
Could you drop a screenshot of the list command for the record in the pr? |
|
Screenshot of
|
jeff-mccoy
changed the title
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
Co-authored-by: Jeff McCoy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebasing the branch
uninstall-the-thingsfrom master