Make init package idempotent #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-mccoy
force-pushed
the
idempotent-init
branch
from
c13f0a2 to
4df2995
Compare
|
@jeff-mccoy @JasonvanBrackel @YrrepNoj thoughts on splitting the test for this into its own task under #774? If we get this in where we can run double inits we could add a new ci workflow for handling upgrade testing. |
|
@Racer159 I'm totally fine with that |
|
Oops. lol |
|
Agree with @Racer159. Fine with that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves issues with re-running
zarf initon an existing zarf cluster. Specifically, it resolves an issue with the injector not excluding itself from the mutating webhook and also the seed registry not using persistence causing issues with upgrades.