Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs with package remove #761

Conversation

Racer159
Copy link
Contributor

Description

Fixes two bugs with package remove, one in #760 around component dependencies and another issue with empty namespaces.

Related Issue

Fixes #760

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist before merging

  • Tests have been added/updated as necessary (add the needs-tests label)
  • (Optional) Changes have been linted locally with golangci-lint. (NOTE: We haven't turned on lint checks in the pipeline yet so linting may be hard if it shows a lot of lint errors in places that weren't touched by changes. Thus, linting is optional right now.)

@Racer159 Racer159 merged commit e304918 into master Sep 21, 2022
@Racer159 Racer159 deleted the 760-package-remove-does-not-remove-dependant-components-properly branch September 21, 2022 21:50
jeff-mccoy added a commit that referenced this pull request Sep 23, 2022
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package remove does not remove dependant components properly
3 participants