717 tmpdir flag silently fails when not a real directory #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YrrepNoj
reviewed
Sep 23, 2022
YrrepNoj
reviewed
Sep 29, 2022
Racer159
previously requested changes
Sep 29, 2022
|
@Noxsios your first commit in this PR is not signed: |
|
@Racer159 it looks like all the commits are signed from my perspective |
Ah yeah you're right I was looking at the wrong thing. |
bdfinst
deleted the
717-tmpdir-flag-silently-fails-when-not-a-real-directory
branch
Noxsios
added a commit
that referenced
this pull request
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add error handling to inside of
utils.makeTempDirinstead of handling each instance it is run, since all errors will produce the same outcome. Users must first create the--tempdirpath if they specify it.This means that users will have to do
mkdir -p <some temp path>before they will be able to run using the--tempdirflag. This is already handled in CI tests, which is the reason for the silent error during actual usage.Related Issue
Fixes #717
Type of change