Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows build #832

Merged
merged 58 commits into from
Oct 9, 2022
Merged

windows build #832

merged 58 commits into from
Oct 9, 2022

Conversation

Noxsios
Copy link
Contributor

@Noxsios Noxsios commented Oct 3, 2022 •
edited by jeff-mccoy
Loading

Description

Related Issue

Fixes #426

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist before merging

  • Tests have been added/updated as necessary (add the needs-tests label)
  • Documentation has been updated as necessary (add the needs-docs label)
  • An ADR has been written as necessary (add the needs-adr label) [ 1 2 3 ]
  • (Optional) Changes have been linted locally with golangci-lint. (NOTE: We haven't turned on lint checks in the pipeline yet so linting may be hard if it shows a lot of lint errors in places that weren't touched by changes. Thus, linting is optional right now.)

@Noxsios Noxsios linked an issue Oct 3, 2022 that may be closed by this pull request
Make Windows Release for Zarf #426
Closed
2 tasks
@Noxsios Noxsios changed the title windows build makefile changes windows build Oct 3, 2022
Noxsios added 27 commits October 3, 2022 15:00
@Noxsios
use os idempotent paths
8b8ead5
@Noxsios
debug copy fn during deploy
2311785
@Noxsios
fix bad path
3afdaca
@Noxsios
add chmod777 to rust binary
40f9ab1
@Noxsios
make sure it compiles
479c352
@Noxsios
tweak debug message during copy
ad054a8
@Noxsios
fix bad code
9b505f4
@Noxsios
init windows workflow
7e79f17
@Noxsios
disable other tests for now while working on windows workflow
c11aca6
@Noxsios
merge master
c04ffcd
@Noxsios
adjust scoop install
88f9932
@Noxsios
adjust common test binary for windows
2b8bb4e
@Noxsios
tweak windows workflow
debc755
@Noxsios
tweak components-scripts example to run on windows
31b4ac7
@Noxsios
Merge branch 'master' into 426-make-windows-release-for-zarf
965bfc0
@Noxsios
fix windows paths during 00
3e41c8f
@Noxsios
tweak windows workflow
7dedc12
@Noxsios
add run-cluster-tests flag to tests
56f0101
@Noxsios
make examples component names unique
ae45efa
@Noxsios
fix components-scripts not building on linux
4389c74
@Noxsios
Merge branch 'master' into 426-make-windows-release-for-zarf
ecfcf9d
@Noxsios
adjust package deploy components to have os name in example package c…
5b31cf2 
…omponent scripts
@Noxsios
more pathing fixes
d79fc23
@Noxsios
make sure workflow is building properly
69ebf2b
@Noxsios
fix zarf cache path regex on windows, add : and \
29ea845
@Noxsios
dont run k8s tests if -run-cluster-tests=false
640d1d7
@Noxsios
change from cli flag to env var
478fdc4
@jeff-mccoy
Windows Compatibility PR Cleanup (#860)
226f052 
- add windows release to goreleaser
- fix all k8s tests being skipped in CI
- change injector chmod 777 -> 755
- move aarch musl call from musl.cc -> govcloud (known issue https://github.com/orgs/community/discussions/27906)
- move cluster check to setup vs every test
- add (supposedly) better cache performance for windows
- remove random extra deps added into CI for windows
- publish new injector stage1 binary w/correct tag
@jeff-mccoy
Merge branch 'master' into 426-make-windows-release-for-zarf
4b39764
jeff-mccoy
jeff-mccoy reviewed Oct 7, 2022
View reviewed changes
Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged in all my changes via PR #860, will leave for @JasonvanBrackel and @Racer159 to sanity check before we merge it.

@JasonvanBrackel JasonvanBrackel self-requested a review October 7, 2022 18:15
JasonvanBrackel
JasonvanBrackel previously requested changes Oct 7, 2022
View reviewed changes
.github/workflows/test-windows.yml Show resolved Hide resolved
Makefile Show resolved Hide resolved
src/test/e2e/common.go Show resolved Hide resolved
Racer159
Racer159 previously requested changes Oct 7, 2022
View reviewed changes
examples/component-scripts/zarf.yaml Outdated Show resolved Hide resolved
src/test/e2e/common.go Show resolved Hide resolved
.github/workflows/test-windows.yml Show resolved Hide resolved
jeff-mccoy and others added 12 commits October 7, 2022 18:39
@jeff-mccoy
Merge branch 'master' into 426-make-windows-release-for-zarf
445754e
@jeff-mccoy
remove arch var from make build-* calls in Ci
38ffbf8
@jeff-mccoy
Make windows binary zarf.exe for amd64 to match Linux pattern
299b666
@jeff-mccoy
use New-Item instead of touch for scripts in windows
8cc9cdf
@jeff-mccoy
add windows arm make target
a3734ea
@jeff-mccoy
Just always build ui on windows due to cross-platform headaches w/mak…
9e56fb2 
…efiles....
@Racer159
Merge branch 'master' into 426-make-windows-release-for-zarf
896456a
@jeff-mccoy
more windows compatibility things
12a215c
@jeff-mccoy
Merge remote-tracking branch 'origin/426-make-windows-release-for-zar…
f948aee 
…f' into 426-make-windows-release-for-zarf
@jeff-mccoy
New-Item is slightly diff than touch and breaks on an existing file :-<
02e4f4e
@jeff-mccoy
Merge branch 'master' into 426-make-windows-release-for-zarf
6e5c5cc
@jeff-mccoy
actually include the rest of the changes
ffa7b6f
@jeff-mccoy jeff-mccoy force-pushed the 426-make-windows-release-for-zarf branch from 5744e40 to ffa7b6f Compare October 9, 2022 04:00
@jeff-mccoy jeff-mccoy dismissed stale reviews from JasonvanBrackel and Racer159 October 9, 2022 05:22

Issues resolved

jeff-mccoy
jeff-mccoy approved these changes Oct 9, 2022
View reviewed changes
Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added all final corrections based on @Racer159 & @JasonvanBrackel comments.

@jeff-mccoy jeff-mccoy merged commit 0cf29cf into master Oct 9, 2022
@bdfinst bdfinst deleted the 426-make-windows-release-for-zarf branch February 1, 2023 13:47
Noxsios added a commit that referenced this pull request Mar 8, 2023
@Noxsios @jeff-mccoy
windows build (#832)
68c84b2 
Add windows AMD/ARM builds & CI pipeline

## Related Issue

Fixes #426

Co-authored-by: Jeff McCoy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-mccoy jeff-mccoy jeff-mccoy approved these changes

@JasonvanBrackel JasonvanBrackel JasonvanBrackel left review comments

@Racer159 Racer159 Racer159 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Windows Release for Zarf
4 participants
@Noxsios @jeff-mccoy @JasonvanBrackel @Racer159