Switch to distribution/distribution vs regex hacking for image url pa… #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eventually, the goal is to move this out completely as the injector system is special and shouldn't just be another modular system.
jeff-mccoy
requested review from
YrrepNoj and
Racer159
and removed request for
YrrepNoj
YrrepNoj
reviewed
Oct 11, 2022
YrrepNoj
approved these changes
Oct 11, 2022
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
#876) This PR removes the Frankenstein regex we were using for parsing docker image references and instead uses the same code that the docker registry itself uses for parsing references to handle various edges cases. SHA1 hashes are also replaced with CRC32 for images and git URLs. The image replacement also should support image digests, but more work will need to be done on the usage of crane for image push/pull as digests are not yet preserved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the Frankenstein regex we were using for parsing docker image references and instead uses the same code that the docker registry itself uses for parsing references to handle various edges cases. SHA1 hashes are also replaced with CRC32 for images and git URLs.
The image replacement also should support image digests, but more work will need to be done on the usage of crane for image push/pull as digests are not yet preserved.