Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code schema validation #884

Merged
merged 9 commits into from
Oct 13, 2022

Conversation

Noxsios
Copy link
Contributor

@Noxsios Noxsios commented Oct 11, 2022

Description

Add documentation to be able to use zarf.schema.json as YAML validation for zarf.yaml in VS Code.

Related Issue

Fixes #872

Type of change

  • Documentation addition / change

Checklist before merging

  • Documentation has been updated as necessary (add the needs-docs label)

@Noxsios Noxsios linked an issue Oct 11, 2022 that may be closed by this pull request
@Noxsios Noxsios self-assigned this Oct 11, 2022
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small fixes to make things more clear

docs/4-user-guide/4-vscode.md Show resolved Hide resolved
docs/4-user-guide/4-vscode.md Outdated Show resolved Hide resolved
docs/4-user-guide/4-vscode.md Outdated Show resolved Hide resolved
@Noxsios Noxsios requested a review from Racer159 October 13, 2022 16:08
@Noxsios Noxsios requested review from Madeline-UX and removed request for YrrepNoj October 13, 2022 20:12
Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jeff-mccoy jeff-mccoy dismissed Racer159’s stale review October 13, 2022 21:28

ed92d2ced259a1c6b7bde9e690d00ecdb531901d220d182542961a979bbf214f7c13757a1e0df7c4db9f1a4df9beafd339682a84cdc8e78e3b6da18b6381e169

@jeff-mccoy jeff-mccoy merged commit c7202d2 into master Oct 13, 2022
@jeff-mccoy jeff-mccoy deleted the 872-visual-studio-code-validation-for-zarfyaml branch October 13, 2022 21:41
Noxsios added a commit that referenced this pull request Mar 8, 2023
## Description

<!-- Please include a summary of the change. Any relevant motivation or
context is also helpful, as well as any dependencies that are required
for this change -->

Add documentation to be able to use `zarf.schema.json` as YAML
validation for `zarf.yaml` in VS Code.

## Related Issue

<!--- This project prefers to accept pull requests related to open
issues -->
<!--- If suggesting a new feature or change, please discuss it in an
issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps
to reproduce -->

Fixes #872 

## Type of change

<!-- Please delete options that are not relevant -->

- [x] Documentation addition / change

## Checklist before merging

<!-- Please delete options that are not relevant -->

- [x] Documentation has been updated as necessary (add the `needs-docs`
label)

Co-authored-by: Megamind <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual Studio Code validation for zarf.yaml
3 participants