fix init pkg deploy via ui #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-winberry
suggested changes
Oct 13, 2022
Validation that fix is working on my machine.Screen.Recording.2022-10-13.at.11.34.40.AM.mov |
mike-winberry
approved these changes
Oct 13, 2022
jeff-mccoy
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
Overall lgtm, one minor thing we should keep an eye on is the use of default initializers in the frontend, they aren't synced in anyway to the usage in the cmd package so could diverge if we're not careful. I don't have a great solution though rn to make it cleaner without a larger refactor on how we split business / presentation logic for the TUI and GUI.
jeff-mccoy
deleted the
882-ui-not-deploying-optional-components-in-init-package
branch
Noxsios
added a commit
that referenced
this pull request
Mar 8, 2023
## Description There is currently a disconnect between the UI and the CLI experience when `zarf init`ing. This is because the flow of `zarf init` does not strictly follow the same flow that `zarf package deploy` does. `ZarfDeployOptions != ZarfInitOptions`. This PR patches the overall API request flow, but does not add the missing options from `ZarfInitOptions` to the UI. Further discussion is needed in that area. <!-- Please include a summary of the change. Any relevant motivation or context is also helpful, as well as any dependencies that are required for this change --> ## Related Issue <!--- This project prefers to accept pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> Fixes #882 ## Type of change <!-- Please delete options that are not relevant --> - [x] Bug fix (non-breaking change which fixes an issue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is currently a disconnect between the UI and the CLI experience when
zarf initing. This is because the flow ofzarf initdoes not strictly follow the same flow thatzarf package deploydoes.ZarfDeployOptions != ZarfInitOptions.This PR patches the overall API request flow, but does not add the missing options from
ZarfInitOptionsto the UI. Further discussion is needed in that area.Related Issue
Fixes #882
Type of change