Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH Pipeline Cleanup & Move to Distroless + GHCR #913

Merged
merged 43 commits into from
Oct 20, 2022
Merged

GH Pipeline Cleanup & Move to Distroless + GHCR #913

merged 43 commits into from
Oct 20, 2022

Conversation

jeff-mccoy
Copy link
Contributor

@jeff-mccoy jeff-mccoy commented Oct 16, 2022 •
edited
Loading

Fixes #903
Fixes #113
Related to #897

  • Change zarf agent build to distroless vs scratch
  • Push agent image to GHCR instead of Dockerhub
  • Implement composite components to make workflows more DRY
  • Add CodeQL scanning
  • Normalize workflow / job names
  • Disable logfile creation for zarf agent
  • Fix issue with --no-log-file not loading properly
  • Disable log file creation for cobra help commands, tools, version commands
  • Disable svelte unused css warning noise
  • Add CODEOWNERS

@jeff-mccoy jeff-mccoy changed the title initial commit github-actions-refactor Oct 16, 2022
Racer159
Racer159 requested changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall supportive of this, just a few small thingz

.github/workflows/test-external.yml Show resolved Hide resolved
svelte.config.js Show resolved Hide resolved
@jeff-mccoy jeff-mccoy mentioned this pull request Oct 18, 2022
Closed
@jeff-mccoy jeff-mccoy mentioned this pull request Oct 18, 2022
Closed
@jeff-mccoy jeff-mccoy marked this pull request as ready for review October 19, 2022 06:54
@jeff-mccoy jeff-mccoy requested a review from Racer159 October 19, 2022 06:54
@jeff-mccoy jeff-mccoy requested a review from YrrepNoj October 19, 2022 12:50
@jeff-mccoy jeff-mccoy changed the title github-actions-refactor GH Pipeline Cleanup & Move to Distroless + GHCR Oct 19, 2022
@jeff-mccoy
Copy link
Contributor Author

Happy to discuss the codeowner section, I did a combination of orgs + individual GH accounts. I like the transparency/version control benefit of using actual GH accounts over just org accounts.

@jeff-mccoy jeff-mccoy mentioned this pull request Oct 19, 2022
Closed
Racer159
Racer159 requested changes Oct 19, 2022
View reviewed changes
.github/workflows/test-kind.yml Outdated Show resolved Hide resolved
.github/workflows/test-kind.yml Outdated Show resolved Hide resolved
.github/workflows/test-windows.yml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
packages/zarf-agent/manifests/deployment.yaml Show resolved Hide resolved
src/cmd/root.go Outdated Show resolved Hide resolved
Racer159
Racer159 approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unleash the bugs @jeff-mccoy hid in this!

@jeff-mccoy
Copy link
Contributor Author

unleash the bugs @jeff-mccoy hid in this!

...and there will be sooo many!

@jeff-mccoy jeff-mccoy merged commit bb3bd78 into master Oct 20, 2022
@jeff-mccoy jeff-mccoy deleted the actions-refactor branch October 20, 2022 02:52
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
@jeff-mccoy
GH Pipeline Cleanup & Move to Distroless + GHCR (#913)
43e594b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Racer159 Racer159 Racer159 approved these changes

@YrrepNoj YrrepNoj Awaiting requested review from YrrepNoj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build Rootless/Non-Privileged Zarf Agent Container Set up CODEOWNERS
2 participants
@jeff-mccoy @Racer159