920 viper package deploy variables do not work #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Racer159
requested review from
jeff-mccoy,
YrrepNoj and
Noxsios
and removed request for
jeff-mccoy
RothAndrew
reviewed
Oct 17, 2022
jeff-mccoy
previously approved these changes
Oct 18, 2022
jeff-mccoy
reviewed
Oct 18, 2022
|
@jeff-mccoy mentioning this here to link these together: #922 |
YrrepNoj
approved these changes
Oct 18, 2022
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
## Description Fixes a bug where deploy variables are not settable (and adds a test to catch it) ## Related Issue Fixes #920 ## Type of change - [X] Bug fix (non-breaking change which fixes an issue) ## Checklist before merging - [X] Tests have been added/updated as necessary (add the `needs-tests` label) - [X] Documentation has been updated as necessary (add the `needs-docs` label) - [X] (Optional) Changes have been linted locally with [golangci-lint](https://github.com/golangci/golangci-lint). (NOTE: We haven't turned on lint checks in the pipeline yet so linting may be hard if it shows a lot of lint errors in places that weren't touched by changes. Thus, linting is optional right now.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where deploy variables are not settable (and adds a test to catch it)
Related Issue
Fixes #920
Type of change
Checklist before merging
needs-testslabel)needs-docslabel)