Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSON schema for zarf.yaml #927

Merged
merged 5 commits into from
Oct 19, 2022
Merged

Fix JSON schema for zarf.yaml #927

merged 5 commits into from
Oct 19, 2022

Conversation

corang
Copy link
Contributor

@corang corang commented Oct 18, 2022

Description

Type annotation changed for zarfChart fields to create a proper "oneOf" schema.

Related Issue

Fixes #925

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist before merging

  • Documentation has been updated as necessary (add the needs-docs label)

@corang corang requested a review from Racer159 October 18, 2022 15:28
@corang corang self-assigned this Oct 18, 2022
@jeff-mccoy
Copy link
Contributor

I noticed this issue the other day too, can you provide a screenshot (maybe before/after) of the issue resolved in vscode?

Racer159
Racer159 requested changes Oct 19, 2022
View reviewed changes
src/types/component.go Show resolved Hide resolved
@Racer159 Racer159 self-requested a review October 19, 2022 19:11
@corang
Copy link
Contributor Author

corang commented Oct 19, 2022 •
edited
Loading

@jeff-mccoy
image

image
Differences are the branch that my settings are referring to master vs 925-schema-error and whether or not there is a red squiggle

@corang
Copy link
Contributor Author

corang commented Oct 19, 2022

Error pop-up
image

@jeff-mccoy jeff-mccoy merged commit 95b5e7a into master Oct 19, 2022
@jeff-mccoy jeff-mccoy deleted the 925-schema-error branch October 19, 2022 20:52
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
@corang @jeff-mccoy
Fix JSON schema for zarf.yaml (#927)
8359723 
## Description

Type annotation changed for zarfChart fields to create a proper "oneOf"
schema.

## Related Issue



Fixes #925 

## Type of change

- [X] Bug fix (non-breaking change which fixes an issue)

## Checklist before merging

<!-- Please delete options that are not relevant -->
- [X] Documentation has been updated as necessary (add the `needs-docs`
label)

Co-authored-by: Megamind <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-mccoy jeff-mccoy jeff-mccoy left review comments

@Racer159 Racer159 Racer159 approved these changes

Assignees

@corang corang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON Schema oneOf for zarf chart is incorrect
3 participants
@corang @jeff-mccoy @Racer159