Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Updated typos on the 0-zarf-overview.md page. #974

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

TheFutonEng
Copy link
Contributor

@TheFutonEng TheFutonEng commented Nov 3, 2022

Description

I found some typos reviewing the Zarf docs site, specifically the overview page.

Related Issue

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist before merging

  • Tests have been added/updated as necessary (add the needs-tests label)
  • Documentation has been updated as necessary (add the needs-docs label)
  • An ADR has been written as necessary (add the needs-adr label) [ 1 2 3 ]
  • (Optional) Changes have been linted locally with golangci-lint. (NOTE: We haven't turned on lint checks in the pipeline yet so linting may be hard if it shows a lot of lint errors in places that weren't touched by changes. Thus, linting is optional right now.)

jeff-mccoy
jeff-mccoy previously approved these changes Nov 3, 2022
YrrepNoj
YrrepNoj previously approved these changes Nov 7, 2022
Copy link
Contributor

@YrrepNoj YrrepNoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. I'll meet up with you later today to sort of the GPG key stuff so we can get this merged in :)

@TheFutonEng TheFutonEng dismissed stale reviews from YrrepNoj and jeff-mccoy via 05943b7 November 7, 2022 16:51
@TheFutonEng TheFutonEng force-pushed the zarf-overview-md-update branch from 9fd347c to 05943b7 Compare November 7, 2022 16:51
@YrrepNoj YrrepNoj merged commit 8fdb16b into master Nov 7, 2022
@YrrepNoj YrrepNoj deleted the zarf-overview-md-update branch November 7, 2022 16:58
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
I found some typos reviewing the Zarf docs site, specifically the
[overview page](https://docs.zarf.dev/docs/zarf-overview).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants